ams-tschoening commented on issue #14: Replace ant build with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#issuecomment-584023353
 
 
   > I have no idea where that `?` comes from...
   
   I think the log settings and witnesses were simply wrong, because the test 
has been disabled so long. `%C` gets the issuing class of a log statement, 
which might not be possible at all if a message is sent over network. `%c` 
works perfectly instead, maybe `%C` had a different fallback than `?` in the 
past? the following commit describes the changes after which all tests succeed 
for me:
   
   
https://github.com/apache/logging-log4cxx/commit/0baf6074cbfcf40026b4e41d25734944cb58df7c
   
   I've additionally applied reformatting to the code, because non-tests have 
been reformatted in the past already and the tests were pretty inconsistent 
with indentation and stuff. Things look good to merge for me now. I won't have 
the time to test the CMAKE-stuff myself, but problems can be solved in master 
in future as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to