ams-tschoening commented on a change in pull request #14: Replace ant build 
with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376907831
 
 

 ##########
 File path: src/test/cpp/net/socketservertestcase.cpp
 ##########
 @@ -478,4 +477,4 @@ LOGUNIT_CLASS(SocketServerTestCase)
 const File SocketServerTestCase::TEMP("output/temp");
 const File SocketServerTestCase::FILTERED("output/filtered");
 
-LOGUNIT_TEST_SUITE_REGISTRATION_DISABLED(SocketServerTestCase)
+LOGUNIT_TEST_SUITE_REGISTRATION(SocketServerTestCase)
 
 Review comment:
   The point is not about different executables, but that this one test case 
only requires additional Java and is difficult to setup. It has been disabled 
in the past for a long time already:
   
   
https://github.com/apache/logging-log4cxx/commit/b279aa7922fe8cbdc3ab2da524e1d6a9ed3913bb#diff-78b9ec5d590a88f742877f2f096c52a9R51

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to