stephen-webb commented on a change in pull request #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376848071
########## File path: src/test/java/CMakeLists.txt ########## @@ -0,0 +1,18 @@ +include(FetchContent) +FetchContent_Declare(log4j + URL https://www-us.apache.org/dist/logging/log4j/1.2.17/log4j-1.2.17.tar.gz + URL_HASH MD5=8218714e41ee0c6509dcfeafa2e1f53f +) +FetchContent_GetProperties(log4j) +if(NOT log4j_POPULATED) + FetchContent_Populate(log4j) +endif() +set(log4j_CLASSPATH "${log4j_SOURCE_DIR}/log4j-1.2.17.jar" ) +set(SOCKET_SERVER_SOURCES org/apache/log4j/net/ShortSocketServer.java) +add_custom_target(test-classes + COMMAND ${Java_JAVAC_EXECUTABLE} -d ${CMAKE_CURRENT_BINARY_DIR} + --class-path "${log4j_CLASSPATH}" ${SOCKET_SERVER_SOURCES} Review comment: I have changed it to -classpath ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
