[
https://issues.apache.org/jira/browse/LOGCXX-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185640#comment-17185640
]
Thorsten Schöning edited comment on LOGCXX-510 at 8/27/20, 6:29 AM:
--------------------------------------------------------------------
You are right, the following statement works for me as well. Must have missed
that the real problem was XML and most likely changed both at the same time.
{noformat}
set(LOG4CXX_DLL_DIR "$<SHELL_PATH:$<TARGET_FILE_DIR:log4cxx>>;")
{noformat}
Regarding XML, why not simply introduce a variable like is available for APR
already? That way people can easily configure whichever XML they like. In the
end, I seem to even use a more standard directory layout than you, because I
didn't change any defaults of CMAKE to place all DLLs into one and the same
directory and with that setup one needs to configure XML individually.
Additionally, is there some way to run CTEST from Visual Studio with additional
environment variables per project or alike? I don't have "sed.exe" in PATH
currently and simply added it where necessary in the past in already available
test running scripts. This doesn't work with the current workflow, CTEST only
knows the environment or what's available in its own files.
Currently it seems I need to add "sed.exe" etc. to the PATH of the user.
was (Author: tschoening):
You are right, the following statement works for me as well. Must have missed
that the real problem was XML and most likely changed both at the same time.
{noformat}
set(LOG4CXX_DLL_DIR "$<SHELL_PATH:$<TARGET_FILE_DIR:log4cxx>>;")
{noformat}
Regarding XML, why not simply introduce a variable like is available for APR
already? That way people can easily configure whichever XML they like. In the
end, I seem to even use a more standard directory layout than you, because I
didn't change any defaults of CMAKE to place all DLLs into one and the same
directory and with that setup one needs to configure XML individually.
> Build problems using CMAKE and Visual Studio 2019 Community
> -----------------------------------------------------------
>
> Key: LOGCXX-510
> URL: https://issues.apache.org/jira/browse/LOGCXX-510
> Project: Log4cxx
> Issue Type: Bug
> Components: Build
> Affects Versions: 0.11.0
> Reporter: Thorsten Schöning
> Assignee: Thorsten Schöning
> Priority: Major
> Attachments: CMP00079.png, CMakeSettings.json,
> cmake_settings_using_vs_gui.zip, missing_log4cxx_rc.png,
> set_target_properties.png
>
>
> I just tested building log4cxx using CMAKE and Visual Studio 2019 Community.
> Things failed and I want to use this bug to document everything that I've
> found, because for some things I'm not sure how to handle them properly. Will
> create a new branch to maintain the fixes I came along, so that those can at
> best be later reviewed by others. The branch of interest is currently named
> "logcxx_510_cmake_vs2019_compat".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
