[ 
https://issues.apache.org/jira/browse/LOGCXX-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185894#comment-17185894
 ] 

Thorsten Schöning edited comment on LOGCXX-510 at 8/27/20, 2:50 PM:
--------------------------------------------------------------------

Setting "XMLLIB_DLL_DIR" on the shell only isn't a good option, because that 
doesn't easily work when doing things from within IDEs like Visual Studio. I 
was able to do everything else in the IDE in the end. It would be enough 
already to introduce one XML-related variable like is available for APR. Those 
variables are shown in the IDE to be configured, but the XML-related one is not 
visible the same way for some reason.


{noformat}
        get_filename_component(APR_DLL_DIR "${APR_DLL}" DIRECTORY)
        get_filename_component(APR_UTIL_DLL_DIR "${APR_UTIL_DLL}" DIRECTORY)
        get_filename_component(XMLLIB_DLL_DIR "${XMLLIB_DLL}" DIRECTORY)
{noformat}

I would have expected "XMLLIB_DLL" to be asked for like "APR_DLL", but that's 
not the case. We just need to make all those three vars behave the same way. 
That would result in all of those three be stored in "CMakeSettings.json" by 
Visual Studio in the end and all would be well. People can configure those 
things depending on how they build APR. I just don't see why those three 
variables are handled differently by VS.


was (Author: tschoening):
Setting "XMLLIB_DLL_DIR" on the shell only isn't a good option, because that 
doesn't easily work when doing things from within IDEs like Visual Studio. I 
was able to do everything else in the IDE in the end. I would be enough already 
to introduce one XML-related variable like is available for APR. Those 
variables are shown in the IDE to be configured, but the XML-related one is not 
visible the same way for some reason.


{noformat}
        get_filename_component(APR_DLL_DIR "${APR_DLL}" DIRECTORY)
        get_filename_component(APR_UTIL_DLL_DIR "${APR_UTIL_DLL}" DIRECTORY)
        get_filename_component(XMLLIB_DLL_DIR "${XMLLIB_DLL}" DIRECTORY)
{noformat}

I would have expected "XMLLIB_DLL" to be asked for like "APR_DLL", but that's 
not the case. We just need to make all those three vars behave the same way. 
That would result in all of those three be stored in CMakeLists.json by Visual 
Studio in the end and all would be well. People can configure those things 
depending on how they build APR. I just don't see why those three variables are 
handled differently by VS.

> Build problems using CMAKE and Visual Studio 2019 Community
> -----------------------------------------------------------
>
>                 Key: LOGCXX-510
>                 URL: https://issues.apache.org/jira/browse/LOGCXX-510
>             Project: Log4cxx
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 0.11.0
>            Reporter: Thorsten Schöning
>            Assignee: Thorsten Schöning
>            Priority: Major
>         Attachments: CMP00079.png, CMakeSettings.json, 
> cmake_settings_using_vs_gui.zip, missing_log4cxx_rc.png, 
> set_target_properties.png
>
>
> I just tested building log4cxx using CMAKE and Visual Studio 2019 Community. 
> Things failed and I want to use this bug to document everything that I've 
> found, because for some things I'm not sure how to handle them properly. Will 
> create a new branch to maintain the fixes I came along, so that those can at 
> best be later reviewed by others. The branch of interest is currently named 
> "logcxx_510_cmake_vs2019_compat".



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to