[ 
https://issues.apache.org/jira/browse/LOGCXX-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190471#comment-17190471
 ] 

Robert Middleton edited comment on LOGCXX-510 at 9/4/20, 1:51 AM:
------------------------------------------------------------------

I tried this out on my side, and something was messed up with it - not sure 
what.

 

however, it seems like the best solution here is to simply use the 
(already-existing) FindEXPAT CMake module, and use that: 
[https://github.com/apache/logging-log4cxx/commit/3ac7bff2d320334660d5be7bc1513025f231fedb]

 

Also to note: there is a CMAKE_PROGRAM_PATH intended for use with find_program, 
so I'm looking into that at the moment too: 
https://cmake.org/cmake/help/v3.13/variable/CMAKE_PROGRAM_PATH.html


was (Author: rmiddleton):
I tried this out on my side, and something was messed up with it - not sure 
what.

 

however, it seems like the best solution here is to simply use the 
(already-existing) FindEXPAT CMake module, and use that: 
https://github.com/apache/logging-log4cxx/commit/3ac7bff2d320334660d5be7bc1513025f231fedb

> Build problems using CMAKE and Visual Studio 2019 Community
> -----------------------------------------------------------
>
>                 Key: LOGCXX-510
>                 URL: https://issues.apache.org/jira/browse/LOGCXX-510
>             Project: Log4cxx
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 0.11.0
>            Reporter: Thorsten Schöning
>            Assignee: Thorsten Schöning
>            Priority: Major
>         Attachments: CMP00079.png, CMakeSettings.json, 
> cmake_settings_using_vs_gui 02.png, cmake_settings_using_vs_gui.zip, 
> missing_log4cxx_rc.png, set_target_properties.png
>
>
> I just tested building log4cxx using CMAKE and Visual Studio 2019 Community. 
> Things failed and I want to use this bug to document everything that I've 
> found, because for some things I'm not sure how to handle them properly. Will 
> create a new branch to maintain the fixes I came along, so that those can at 
> best be later reviewed by others. The branch of interest is currently named 
> "logcxx_510_cmake_vs2019_compat".



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to