ppkarwasz opened a new pull request #704: URL: https://github.com/apache/logging-log4j2/pull/704
The unit tests provided by `Log4j1ConfigurationFactoryTest` unfortunately were not applied to the newer `PropertiesConfigurationFactory` and `XmlConfigurationFactory`. After applying the tests, many small errors appeared, which this PR solves: * the `XmlConfiguration` didn't allow for system property replacement ([LOG4J2-3328]), * the `TTCCLayoutBuilder` lacked proper default values for its properties, * the `RollingFileAppender` and `DailyRollingFileAppender` used incorrect file patterns, * the `XmlLayoutBuilder` used the native Log4j 2.x `XmlLayout` instead of the compatible `Log4j1XmlLayout`, * builders that did not inherit from `AbstractBuilder` failed to be instantiated. For an easier cherry-pick, I tried to solve each problem in a separate commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
