ppkarwasz edited a comment on pull request #704: URL: https://github.com/apache/logging-log4j2/pull/704#issuecomment-1013950184
Sorry @garydgregory, I didn't plan to provide a fix to LOG4J2-3328 at first, but some of the tests I copied from `Log4j1ConfigurationFactoryTest` were failing... :-D I rebased my PR on top of your changes. The number of changed files is still high (30), but only 18 are Java files (I added 11 Log4j 1.x style XML configuration files) and only 14 are in the main code. The list of changes: * the `TTCCLayoutBuilder` lacked proper default values for its properties, * the `RollingFileAppender` and `DailyRollingFileAppender` used incorrect file patterns, * the `XmlLayoutBuilder` used the native Log4j 2.x `XmlLayout` instead of the compatible `Log4j1XmlLayout`, * builders that did not inherit from `AbstractBuilder` failed to be instantiated, * the `Log4j1ConfigurationParser` used Log4j 2.x `StrSubstitutor` instead of Log4j 1.x `OptionConverter`. Each of these issues requires only a couple of lines to fix, but I can split the PR if it helps. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
