ppkarwasz commented on a change in pull request #704:
URL: https://github.com/apache/logging-log4j2/pull/704#discussion_r785540531
##########
File path:
log4j-1.2-api/src/main/java/org/apache/log4j/builders/AbstractBuilder.java
##########
@@ -86,12 +86,25 @@ protected String getNameAttribute(Element element) {
return element.getAttribute(NAME_ATTR);
}
+ /**
+ * Normalized version of the "name" attribute of the <param> tag.
+ * @param element
+ * @return
+ */
+ protected String getNormalizedNameAttribute(Element element) {
+ return capitalize(getNameAttribute(element));
+ }
+
Review comment:
No, `getNameAttribute` is used for retrieving the `"name"` attribute of
both the `<appender>` and `<param>` tags. I didn't notice this before, but
fortunately some tests failed. AFAIK appender names are case sensitive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
