garydgregory commented on a change in pull request #704:
URL: https://github.com/apache/logging-log4j2/pull/704#discussion_r785534352
##########
File path:
log4j-1.2-api/src/main/java/org/apache/log4j/builders/AbstractBuilder.java
##########
@@ -86,12 +86,25 @@ protected String getNameAttribute(Element element) {
return element.getAttribute(NAME_ATTR);
}
+ /**
+ * Normalized version of the "name" attribute of the <param> tag.
+ * @param element
+ * @return
+ */
+ protected String getNormalizedNameAttribute(Element element) {
+ return capitalize(getNameAttribute(element));
+ }
+
Review comment:
Are all call sites of getNameAttribute() now call sites of this new
method? If so, just update getNameAttribute() IMO.
##########
File path:
log4j-1.2-api/src/main/java/org/apache/log4j/builders/AbstractBuilder.java
##########
@@ -86,12 +86,25 @@ protected String getNameAttribute(Element element) {
return element.getAttribute(NAME_ATTR);
}
+ /**
+ * Normalized version of the "name" attribute of the <param> tag.
+ * @param element
+ * @return
Review comment:
If you add Javadocs, don't do it half-way ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
