JaroslavTulach commented on a change in pull request #2386:
URL: https://github.com/apache/netbeans/pull/2386#discussion_r493162511
##########
File path: ide/parsing.indexing/manifest.mf
##########
@@ -4,4 +4,5 @@ OpenIDE-Module-Localizing-Bundle:
org/netbeans/modules/parsing/indexing/Bundle.p
OpenIDE-Module-Layer: org/netbeans/modules/parsing/impl/indexing/layer.xml
AutoUpdate-Show-In-Client: false
OpenIDE-Module-Implementation-Version: 1
+OpenIDE-Module-Needs:
org.netbeans.modules.parsing.impl.indexing.implspi.ActiveDocumentProvider
Review comment:
I tried to assemble minimal application and I was getting
`IllegalStateException`. Turned out that `parsing.indexing` cannot run without
`ActiveDocumentProvider`. The `OpenIDE-Module-Needs` just formalizes that
dependency. @tzezula may confirm, but the code in `RepositoryUpdater` speaks
clearly:
```java
this.activeDocProvider =
Lookup.getDefault().lookup(ActiveDocumentProvider.class);
if (this.activeDocProvider == null) {
throw new IllegalStateException("No ActiveDocumentProvider
instance in global lookup."); //NOI18N
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
