JaroslavTulach commented on a change in pull request #2386:
URL: https://github.com/apache/netbeans/pull/2386#discussion_r493164127
##########
File path: ide/javascript2.debug/nbproject/project.xml
##########
@@ -114,6 +114,7 @@
<friend-packages>
<friend>org.netbeans.modules.debugger.jpda.js</friend>
<friend>org.netbeans.modules.debugger.jpda.truffle</friend>
+ <friend>org.netbeans.modules.java.lsp.server</friend>
Review comment:
Good catch. This is a change needed for the [java.lsp.server
debugging](https://github.com/JaroslavTulach/netbeans/tree/java-lsp-server-debugging-attempt2),
but not really a cleanup. Moreover one should bump module version when
changing list of friends.
Let's remove the change from this PR: 2847f6e
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
