JaroslavTulach commented on pull request #2386: URL: https://github.com/apache/netbeans/pull/2386#issuecomment-697099157
> Overall seems good to me. Just please re-evaluate the usage of projectui resource bundle for configuration. There are [Branding APIs](https://bits.netbeans.org/dev/javadoc/branding.html) in the NetBeans code base. It is a better than `System.getProperty` way to configure the system (no need to mangle with command line switches), if the configuration is "per application" (which comes with own branding). It is more lightweight than [API seam](http://wiki.apidesign.org/wiki/APISeam). > looks sane to me. I left two inline questions, but these are just to improve my understanding. Answered and fixed in 2847f6e. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
