ebresie commented on a change in pull request #2820:
URL: https://github.com/apache/netbeans/pull/2820#discussion_r610672491



##########
File path: 
ide/db.sql.editor/src/org/netbeans/modules/db/sql/analyzer/SQLStatementAnalyzer.java
##########
@@ -239,6 +239,8 @@ protected QualIdent parseIdentifier() {
     }
 
     protected String getUnquotedIdentifier() {
+        if (quoter == null)
+            return "";

Review comment:
       > Yes SQL defines default quoting behavior - from the top of my head:
   > 
   > * identifiers are quoted with double quotes: `"IDENTIFIER"`
   > * strings are quoted with single quotes: `'STRING'`
   > * escaping the quote itself is handled by doubling itself `""""` is the 
Identifier `"` and `''''` is the string `'`
   > 
   > Sounds simple - it is not because DB vendors screwed up. I remember, that 
MySQL has some more creative quotes and escapes, which make "MySQL SQL" 
incompatible" with "Standard SQL".
   
   Looking at one of the [w3 resources SQL syntax page in identifier 
section](https://www.w3resource.com/sql/sql-syntax.php#IDENTIF) it does look 
more complicated.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to