ebresie commented on a change in pull request #2820:
URL: https://github.com/apache/netbeans/pull/2820#discussion_r610674038
##########
File path:
ide/db.sql.editor/src/org/netbeans/modules/db/sql/analyzer/SQLStatementAnalyzer.java
##########
@@ -239,6 +239,8 @@ protected QualIdent parseIdentifier() {
}
protected String getUnquotedIdentifier() {
+ if (quoter == null)
+ return "";
Review comment:
> As an alternative, in that code it uses the quoter to "unquote" stuff,
but if a quoter is not available (due to lack of connection), could it just
return the text as is with something like?
>
> ```
> if (quoter == null)
> return seq.token().text().toString();
> ```
Is this more acceptable then returning the "" mentioned in the original
comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
