ebresie commented on a change in pull request #2820:
URL: https://github.com/apache/netbeans/pull/2820#discussion_r610696904
##########
File path:
ide/db.sql.editor/src/org/netbeans/modules/db/sql/analyzer/SQLStatementAnalyzer.java
##########
@@ -239,6 +239,8 @@ protected QualIdent parseIdentifier() {
}
protected String getUnquotedIdentifier() {
+ if (quoter == null)
+ return "";
Review comment:
> Looking at one of the [w3 resources SQL syntax page in identifier
section](https://www.w3resource.com/sql/sql-syntax.php#IDENTIF) it does look
more complicated.
The w3 reference mentions after "SELECT" there can be optionally "DISTINCT |
ALL" and either a wildcard ("*") or select List (i.e. identifiers). Unless I've
missed it, I'm not sure these cases are handled. Is a new issue for adding
that worth wild?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
