ebresie commented on a change in pull request #2820:
URL: https://github.com/apache/netbeans/pull/2820#discussion_r610695155



##########
File path: 
ide/db.sql.editor/src/org/netbeans/modules/db/sql/analyzer/SQLStatementAnalyzer.java
##########
@@ -239,6 +239,8 @@ protected QualIdent parseIdentifier() {
     }
 
     protected String getUnquotedIdentifier() {
+        if (quoter == null)
+            return "";

Review comment:
       That said, looking at the w3 reference above, I noticed after "SELECT" 
there can be optionally "DISTINCT | ALL" and can be "*" or select List (i.e. 
identifiers).  Not sure if the handling of DISTINCT, ALL, and/or * might need 
to be added at some point.  You think maybe a new issue for adding that would 
be worth wild? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to