eirikbakke commented on pull request #3414: URL: https://github.com/apache/netbeans/pull/3414#issuecomment-1007228601
I started looking through this, but I'm boarding a plane now and haven't finished reviewing yet... Adding URI in addition to URL seems to add a lot of complexity, and potential for confusion. Perhaps just add an optional String identifier, and then let icons be looked up by either the URL (if present) or the optional identifier? There's a number of hacks that could add complexity here... I remember dealing with icon/image wrappers when adding SVG support, and it was a source of pain. I will look more closely through this patch again in a day or two. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
