sdedic edited a comment on pull request #3414:
URL: https://github.com/apache/netbeans/pull/3414#issuecomment-1007237041
> Adding URI in addition to URL seems to add a lot of complexity, and
potential for confusion. Perhaps just add an optional String identifier, and
then let icons be looked up by either the URL (if present) or the optional
identifier?
>
This ("url" + "id") is the conceptually the same as "url" + "uri", it is
that dichotomy itself that is the centre of the heated philosophical debate.
BTW as a improvement, there could be always an ID (String, URI), possibly
derived from a supplied load URL _but_ unaffected by branding / localization
computed internally by `ImageUtilities` (hey, another benefit of the
duplication !) and sometimes possibly URL. Then a client may choose to get just
the property it is interested in (location, identification). The current client
code in the patch queries both, which is confusing; will fix.
Except that, URI has at least some structure :) compared to String, with
Strings, we would still need to invent some convention (e.g. prefixing) so that
ids from different sources remain unique (i.e. I should not probably provide
just "Tree.openIcon", that's likely to clash, but "something.Tree.openIcon" ...
which is quite equivalent to an URL/URI scheme + host / path).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
