eirikbakke commented on pull request #3414: URL: https://github.com/apache/netbeans/pull/3414#issuecomment-1007465043
As long as there is an "url" field, having an "uri" field as well be confusing. People will not be able to guess what they are used for, and if something starts with "http://";, then anyone looking at it will assume it points to a physical file somewhere. (Unless they are intimately familiar with XML namespace conventions.) Having an optional String property called "logicalIconID" would be clearer. Then we don't have to try to convert between URL and URI either, and the code for setting the "url" parameter can remain untouched. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
