JaroslavTulach commented on a change in pull request #3414:
URL: https://github.com/apache/netbeans/pull/3414#discussion_r780051773



##########
File path: java/java.lsp.server/vscode/schemas/package.schema.json
##########
@@ -0,0 +1,42 @@
+{
+    "$schema": "http://json-schema.org/draft-07/schema#";,
+    "title": "LSP Image Resource Mapping contributions to package.json",
+    "type": "object",
+    "properties": {
+            "contributes": {
+                    "type": "object",
+                    "properties": {
+                            "netbeans.iconMapping" : {

Review comment:
       package.json!?
   
   No need to add it into `arch.xml` - this is really VSNetBeans specific. 
However other extension writers should know how much they can rely on this. I'd 
also like to know whether we want to support this `iconMapping` _forever_ or 
rewrite it the next version?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to