sdedic commented on pull request #3414: URL: https://github.com/apache/netbeans/pull/3414#issuecomment-1008067595
@JaroslavTulach @eirikbakke it seems that some consensus is bulding finally. Let me recap: - I need some 'identifier' to identify icon for replacement; that can be sometimes derived from resource URL, but sometimes not. - Client should make one call or extraction, not a series of get + instanceof - URI is rather confusable with URL for other people than XML veterans, so people could choose wrong thing from URL/URI alternatives (especially when most of the time URI would be URL) So ... I am going to: - change the type to String, document minimal rules for uniqueness - provide a helper static method to get URL and an (String) identifier (the instanceof cascade will be here) - propagate "id" and "url" separately, not derive one form the other in ImageUtilities impl. All OK ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
