[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #3489: text areas in search+replace dialog now pretend to be text fields if still small enough.

Fri, 21 Jan 2022 23:39:49 -0800 


matthiasblaesing commented on a change in pull request #3489:
URL: https://github.com/apache/netbeans/pull/3489#discussion_r790115245



##########
File path: 
platform/api.search/src/org/netbeans/modules/search/BasicSearchForm.java
##########
@@ -1119,8 +1121,23 @@ private void limitReached() {
         public MultiLineComboBoxEditor() {
             area.setWrapStyleWord(false);
             area.setLineWrap(false);
+
+            // retain standard focus traversal behavior
             
area.setFocusTraversalKeys(KeyboardFocusManager.FORWARD_TRAVERS‌​AL_KEYS, null);
             
area.setFocusTraversalKeys(KeyboardFocusManager.BACKWARD_TRAVERS‌​AL_KEYS, 
null);
+
+            // pretend to be a single line text field if you are small enough
+            area.addKeyListener(new KeyAdapter() {

Review comment:
       This will break accessibility. As a developer you know, that the 
behavior, but a user will not know and will be surprised if the field suddenly 
changes bahaviour. How about a toggle button, that switches between single and 
multiline case? Activating that could even provide a textarea, that is large 
enough by default to show multiple lines of text.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to