[GitHub] [netbeans] neilcsmith-net commented on a change in pull request #3489: text areas in search+replace dialog now pretend to be text fields if still small enough.

Sat, 22 Jan 2022 03:36:23 -0800 


neilcsmith-net commented on a change in pull request #3489:
URL: https://github.com/apache/netbeans/pull/3489#discussion_r790133587



##########
File path: 
platform/api.search/src/org/netbeans/modules/search/BasicSearchForm.java
##########
@@ -1119,8 +1121,23 @@ private void limitReached() {
         public MultiLineComboBoxEditor() {
             area.setWrapStyleWord(false);
             area.setLineWrap(false);
+
+            // retain standard focus traversal behavior
             
area.setFocusTraversalKeys(KeyboardFocusManager.FORWARD_TRAVERS‌​AL_KEYS, null);
             
area.setFocusTraversalKeys(KeyboardFocusManager.BACKWARD_TRAVERS‌​AL_KEYS, 
null);
+
+            // pretend to be a single line text field if you are small enough
+            area.addKeyListener(new KeyAdapter() {

Review comment:
       @mbien `CTRL+ENTER` works fine. You're reading my comment the opposite 
of how it was intended.  For those of use who've used this for decades, 
switching away from just `ENTER` takes some relearning of muscle memory! :smile:
   
   How about we do the reverse here anyway? Other UIs (not NetBeans) use 
`SHIFT+ENTER` or `ALT+ENTER` to type newline in these sort of cases. Let's keep 
the default behaviour as it was.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to