matthiasblaesing commented on a change in pull request #3489:
URL: https://github.com/apache/netbeans/pull/3489#discussion_r790120021
##########
File path:
platform/api.search/src/org/netbeans/modules/search/BasicSearchForm.java
##########
@@ -1119,8 +1121,23 @@ private void limitReached() {
public MultiLineComboBoxEditor() {
area.setWrapStyleWord(false);
area.setLineWrap(false);
+
+ // retain standard focus traversal behavior
area.setFocusTraversalKeys(KeyboardFocusManager.FORWARD_TRAVERSAL_KEYS, null);
area.setFocusTraversalKeys(KeyboardFocusManager.BACKWARD_TRAVERSAL_KEYS,
null);
+
+ // pretend to be a single line text field if you are small enough
+ area.addKeyListener(new KeyAdapter() {
Review comment:
Still **I** would not guess, that I have to resize the dialog to do
multiline searches and this has zero discoverability. The dialog is big enough,
so why would I resize it?
Also think about people with bad eyesight, using assistive technologies,
they will even be worse, because not only have they use their tech, the UI
suddenly changes behavior, just because it was scaled.
For the toggle button. Toggling it can remove newlines or turn the search to
regexp based search, that will happily serach for newlines even before this
change. It would also be clearer, because a button can be expected to change
behavior, resizing in my mind can't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
