[GitHub] [netbeans] mbien commented on a change in pull request #3489: text areas in search+replace dialog now pretend to be text fields if still small enough.

Sat, 22 Jan 2022 02:35:26 -0800 


mbien commented on a change in pull request #3489:
URL: https://github.com/apache/netbeans/pull/3489#discussion_r790128802



##########
File path: 
platform/api.search/src/org/netbeans/modules/search/BasicSearchForm.java
##########
@@ -1119,8 +1121,23 @@ private void limitReached() {
         public MultiLineComboBoxEditor() {
             area.setWrapStyleWord(false);
             area.setLineWrap(false);
+
+            // retain standard focus traversal behavior
             
area.setFocusTraversalKeys(KeyboardFocusManager.FORWARD_TRAVERS‌​AL_KEYS, null);
             
area.setFocusTraversalKeys(KeyboardFocusManager.BACKWARD_TRAVERS‌​AL_KEYS, 
null);
+
+            // pretend to be a single line text field if you are small enough
+            area.addKeyListener(new KeyAdapter() {

Review comment:
       @neilcsmith-net please give it a try first and test it. This PR should 
restore the original behavior. We can improve discoverability of the multi line 
feature later - this has low priority for me. A hidden feature is not a bug, 
this PR fixes a regression caused by 
https://github.com/apache/netbeans/pull/3393.
   
   just to be to be sure i repeat: this PR changes nothing regarding 
discoverability, it restores original behavior so that if you are used to Enter 
as action trigger, you can keep using it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to