[GitHub] [netbeans] neilcsmith-net commented on a change in pull request #3489: text areas in search+replace dialog now pretend to be text fields if still small enough.

Sat, 22 Jan 2022 06:28:17 -0800 


neilcsmith-net commented on a change in pull request #3489:
URL: https://github.com/apache/netbeans/pull/3489#discussion_r790147807



##########
File path: 
platform/api.search/src/org/netbeans/modules/search/BasicSearchForm.java
##########
@@ -1119,8 +1121,23 @@ private void limitReached() {
         public MultiLineComboBoxEditor() {
             area.setWrapStyleWord(false);
             area.setLineWrap(false);
+
+            // retain standard focus traversal behavior
             
area.setFocusTraversalKeys(KeyboardFocusManager.FORWARD_TRAVERS‌​AL_KEYS, null);
             
area.setFocusTraversalKeys(KeyboardFocusManager.BACKWARD_TRAVERS‌​AL_KEYS, 
null);
+
+            // pretend to be a single line text field if you are small enough
+            area.addKeyListener(new KeyAdapter() {

Review comment:
       I'll leave you and @matthiasblaesing to decide over option 2 and his 
suggestion.  I agree with him that anything changing the behaviour based on 
window sizing is the wrong approach, with or without the tip.  Still somewhat 
prefer his suggestion.
   
   Incidentally `SHIFT+ENTER` and `ALT+ENTER` are commons ways to handle this 
in chat programs and spreadsheets, so not that unintuitive, particularly as a 
retrofit.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to