mbien commented on a change in pull request #3489:
URL: https://github.com/apache/netbeans/pull/3489#discussion_r790137743
##########
File path:
platform/api.search/src/org/netbeans/modules/search/BasicSearchForm.java
##########
@@ -1119,8 +1121,23 @@ private void limitReached() {
public MultiLineComboBoxEditor() {
area.setWrapStyleWord(false);
area.setLineWrap(false);
+
+ // retain standard focus traversal behavior
area.setFocusTraversalKeys(KeyboardFocusManager.FORWARD_TRAVERSAL_KEYS, null);
area.setFocusTraversalKeys(KeyboardFocusManager.BACKWARD_TRAVERSAL_KEYS,
null);
+
+ // pretend to be a single line text field if you are small enough
+ area.addKeyListener(new KeyAdapter() {
Review comment:
> > thats the version right now after this PR. Enter works, no change in
behavior form 12.6.
>
> Until you resize the dialog, then "magic" happens. The "magic" part is
what I don't like. It is not discoverable and can't be observed by
accessibility tools. As a user you have to "know" that something will happen or
you don't and get surprised.
I have to disagree there since that is how everyone should expect a larger
text field to work - what else should happen if you edit a multi line text area
and press enter?
As before mentioned CTRL+ENTER works too (it always did). So if you want I
could add it as initial info msg as in your version.
To me this is all surprisingly off topic. Since this PR restores original
behavior while most discussion is about how to make the (new) multiline feature
more discoverable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
