mbien commented on a change in pull request #3489:
URL: https://github.com/apache/netbeans/pull/3489#discussion_r790144384
##########
File path:
platform/api.search/src/org/netbeans/modules/search/BasicSearchForm.java
##########
@@ -1119,8 +1121,23 @@ private void limitReached() {
public MultiLineComboBoxEditor() {
area.setWrapStyleWord(false);
area.setLineWrap(false);
+
+ // retain standard focus traversal behavior
area.setFocusTraversalKeys(KeyboardFocusManager.FORWARD_TRAVERSAL_KEYS, null);
area.setFocusTraversalKeys(KeyboardFocusManager.BACKWARD_TRAVERSAL_KEYS,
null);
+
+ // pretend to be a single line text field if you are small enough
+ area.addKeyListener(new KeyAdapter() {
Review comment:
@neilcsmith-net
the screenshot above, option 1:
- says press CTRL+ENTER just like in Matthias'es version (just wanting to
make sure that you didn't overlook it)
- it addresses the discoverability issue by suggesting to resize the window
for multi line use
option 2:
- add resize info text just like above for discoverability (but don't
mention CTRL+ENTER)
- always dispatch ENTER as dialog action
- use SHIFT+ENTER as new line action as you suggested (and mention it in
the msg)
I would prefer 1 since it has identical behavior to 12.6 and the hint msg
clearly describes how to use the new feature. Option 2 is close second since it
requires to use unintuitive SHIFT+ENTER for newline in text areas, but since
its a niche feature, i would be ok with it.
I would also like to avoid making the textfields larger by default since it
makes the dialog uglier for the most common usecase: single line search
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
