[GitHub] [netbeans] neilcsmith-net commented on a change in pull request #3489: text areas in search+replace dialog now pretend to be text fields if still small enough.

Sat, 22 Jan 2022 05:12:55 -0800 


neilcsmith-net commented on a change in pull request #3489:
URL: https://github.com/apache/netbeans/pull/3489#discussion_r790141491



##########
File path: 
platform/api.search/src/org/netbeans/modules/search/BasicSearchForm.java
##########
@@ -1119,8 +1121,23 @@ private void limitReached() {
         public MultiLineComboBoxEditor() {
             area.setWrapStyleWord(false);
             area.setLineWrap(false);
+
+            // retain standard focus traversal behavior
             
area.setFocusTraversalKeys(KeyboardFocusManager.FORWARD_TRAVERS‌​AL_KEYS, null);
             
area.setFocusTraversalKeys(KeyboardFocusManager.BACKWARD_TRAVERS‌​AL_KEYS, 
null);
+
+            // pretend to be a single line text field if you are small enough
+            area.addKeyListener(new KeyAdapter() {

Review comment:
       @mbien this doesn't restore the old behaviour. As Matthias says it adds 
"magic". So, we can restore the old behaviour by reverting the UI changes for 
multiline, make things clearer as Matthias' change does, or change the newline 
key to be `SHIFT+ENTER` or `ALT+ENTER` which is similar to other software.  I'd 
be happy if we got any of those 3 options in to NB13, but disagree on the 
behaviour in this PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to