mbien commented on code in PR #4431:
URL: https://github.com/apache/netbeans/pull/4431#discussion_r930974642
##########
.github/workflows/main.yml:
##########
@@ -335,7 +907,9 @@ jobs:
- name: Test PHP Doctrine2
run: ant $OPTS -f php/php.doctrine2 test
+ # todo: longest step -> needs 2 tiers, with tier 2 conditional
- name: Test PHP Editor
+ if: contains(github.event.pull_request.labels.*.name, 'PHP') ||
github.event_name != 'pull_request'
run: ant $OPTS -f php/php.editor test
Review Comment:
path triggers are per-workflow, not per-job. The pipeline does only work
within a workflow where artifacts can be shared. So we would have to implement
our own condition script which checks paths somehow to conditionally run jobs.
but the main difference: devs set labels. If a reviewer wants all tests to
run it could be easily set. Or if tier1 is fine only fast tests are run.
Automating this does rarely work. Calculating the paths would basically
trigger everything all the time, see
https://github.com/apache/netbeans/pull/3727#issuecomment-1061752817
And what it it doesn't trigger but you want it to trigger? You still need
some fallback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
