mbien commented on code in PR #4431:
URL: https://github.com/apache/netbeans/pull/4431#discussion_r930988096


##########
.github/workflows/main.yml:
##########
@@ -335,7 +907,9 @@ jobs:
       - name: Test PHP Doctrine2
         run: ant $OPTS -f php/php.doctrine2 test
 
+      # todo: longest step -> needs 2 tiers, with tier 2 conditional
       - name: Test PHP Editor
+        if: contains(github.event.pull_request.labels.*.name, 'PHP') || 
github.event_name != 'pull_request'
         run: ant $OPTS -f php/php.editor test

Review Comment:
   btw I don't think we should label trigger everything, only jobs which are 
long enough. The profiler job runs in <2 mins, there is not much to be gained 
to conditionally run this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to