mbien commented on code in PR #3: URL: https://github.com/apache/netbeans-native-installers/pull/3#discussion_r1052458868
########## src/main/cpp/cleaner/windows/Makefile.mingw: ########## @@ -16,5 +14,18 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. -# +TMPFLD = ../../../../../target/tmp/ +OFLD = ../../../../../target/cleaner/ + +all: prepfolder cleaner.exe + +prepfolder: + mkdir -p $(TMPFLD) + mkdir -p $(OFLD) + +clean: + rm -f *.res *.exe *.dll + +cleaner.exe: src/main.c + x86_64-w64-mingw32-gcc -s -DARCHITECTURE=64 -Wl,--nxcompat -Wl,--dynamicbase -Wl,--no-seh -Wl,--no-insert-timestamp -mwindows src/main.c -o$(OFLD)cleaner.exe -static -lstdc++ -static-libstdc++ -static-libgcc Review Comment: even my old raspery pi 3 runs on a mainline 64 bit kernel :) I don't think NB should bother with 32bit anymore. There is also nothing in the CI pipeline which is testing anything on 32bit JVMs right now - it makes sense to me to concentrate on 64bit only for sake of simplicity and reduced test workload. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
