neilcsmith-net commented on code in PR #3: URL: https://github.com/apache/netbeans-native-installers/pull/3#discussion_r1052654022
########## src/main/cpp/cleaner/windows/Makefile.mingw: ########## @@ -16,5 +14,18 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. -# +TMPFLD = ../../../../../target/tmp/ +OFLD = ../../../../../target/cleaner/ + +all: prepfolder cleaner.exe + +prepfolder: + mkdir -p $(TMPFLD) + mkdir -p $(OFLD) + +clean: + rm -f *.res *.exe *.dll + +cleaner.exe: src/main.c + x86_64-w64-mingw32-gcc -s -DARCHITECTURE=64 -Wl,--nxcompat -Wl,--dynamicbase -Wl,--no-seh -Wl,--no-insert-timestamp -mwindows src/main.c -o$(OFLD)cleaner.exe -static -lstdc++ -static-libstdc++ -static-libgcc Review Comment: @lbruun it's no secret I'd like to replace NBI in its entirety anyway (so I'm in favour). But sometimes people surprise with how they're using the platform, or what they're relying on. Is support shipped now? If so, at least some mention on dev@ would be good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
