mbien commented on code in PR #3: URL: https://github.com/apache/netbeans-native-installers/pull/3#discussion_r1052482219
########## src/main/cpp/cleaner/windows/Makefile.mingw: ########## @@ -16,5 +14,18 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. -# +TMPFLD = ../../../../../target/tmp/ +OFLD = ../../../../../target/cleaner/ + +all: prepfolder cleaner.exe + +prepfolder: + mkdir -p $(TMPFLD) + mkdir -p $(OFLD) + +clean: + rm -f *.res *.exe *.dll + +cleaner.exe: src/main.c + x86_64-w64-mingw32-gcc -s -DARCHITECTURE=64 -Wl,--nxcompat -Wl,--dynamicbase -Wl,--no-seh -Wl,--no-insert-timestamp -mwindows src/main.c -o$(OFLD)cleaner.exe -static -lstdc++ -static-libstdc++ -static-libgcc Review Comment: > Yeah, well it is not about the OS. It is about the JRE. It is not uncommon to see people execute their workload on a 32-bit JRE (even on a very modern, latest and greatest 64-bit Windows or Linux OS), because it gives less memory consumption. this used to be the case long ago. Today, all JVMs/GCs have support for compressed opps (enabled by default). And if you really do care about footprint to such extend that it matters there would be native images. (and even raspis have GBs of memory, I run three containers with 64bit JVMs in them on an old 1gb model and have still memory left) > But those are ETL workloads. I don't know if anyone would find it beneficial to execute their NetBeans IDE or NetBeans Platform application in 32 bit? right > Yes, that would be dev@ wink Suggest bringing it up there. i would be curious if it even works today given that probably nobody is testing this scenario. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
