lbruun commented on code in PR #3: URL: https://github.com/apache/netbeans-native-installers/pull/3#discussion_r1053546811
########## src/main/cpp/cleaner/windows/Makefile.mingw: ########## @@ -16,5 +14,18 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. -# +TMPFLD = ../../../../../target/tmp/ +OFLD = ../../../../../target/cleaner/ + +all: prepfolder cleaner.exe + +prepfolder: + mkdir -p $(TMPFLD) + mkdir -p $(OFLD) + +clean: + rm -f *.res *.exe *.dll + +cleaner.exe: src/main.c + x86_64-w64-mingw32-gcc -s -DARCHITECTURE=64 -Wl,--nxcompat -Wl,--dynamicbase -Wl,--no-seh -Wl,--no-insert-timestamp -mwindows src/main.c -o$(OFLD)cleaner.exe -static -lstdc++ -static-libstdc++ -static-libgcc Review Comment: > I only target x64 as it was done in the launcher repo this way. There is only one cleaner.exe in the zip ([nbi](https://netbeans.osuosl.org/binaries/2B892D9E648A792EDB0F705378E06F84C322E208-nbi.engine-external-binaries-11.zip)) that I cannot determine the architecture. I've downloaded that existing ZIP in order to determine the bit-size of the `cleaner.exe` within that ZIP. The result: ```text C:\Users\lars\Downloads>c:\tools\Microsoft-SysInternals\sigcheck.exe cleaner.exe Sigcheck v2.73 - File version and signature viewer Copyright (C) 2004-2019 Mark Russinovich Sysinternals - www.sysinternals.com C:\Users\lars\Downloads\cleaner.exe: Verified: Unsigned Link date: 13:42 14-01-2010 Publisher: n/a Company: n/a Description: n/a Product: n/a Prod version: n/a File version: n/a MachineType: 32-bit ``` It is 32-bit !! (not sure, that it matters, though) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
