BradWalker commented on PR #5487: URL: https://github.com/apache/netbeans/pull/5487#issuecomment-1429879655
> please don't ever merge PRs which don't have tests run on them! This PR broke master. There is no need to hurry. > > This is a project wide cleanup which requires all tests to be run which is activated with the `ci:all-tests` label. As someone who has previously worked on things in this area, I spent the time to look at each file that was changed. So I'll accept the responsibility for what happened. It appeared to me that the tests were being "skipped" by design. Previously when I've looked at the test runs, the system always showed as "failed". So it was clearly my mistake. My apologies to everyone! I'll be more diligent next time! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
