mbien commented on PR #5487: URL: https://github.com/apache/netbeans/pull/5487#issuecomment-1430807423
also regarding large cleanup PRs in general: in my book they are fine as long they remain reviewable (of course the PR itself should have a purpose too - I am not saying that every possible automated cleanup is worth the review time or to be integrated). It helps a lot to split large PRs into commits - if someone would only have the time to review one commit, thats fine - add a comment to tell the next reviewer. We can't split everything into PRs otherwise every project wide cleanup would mean 18 PRs, one for each cluster - lets not do that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
