mbien commented on PR #5487: URL: https://github.com/apache/netbeans/pull/5487#issuecomment-1429891166
the changes itself were fine, the problem was that some were in test data. Just don't be so quick with the merge button next time. It is perfectly fine to let a PR sit a few days - increases the probability that someone notices things like this, e.g missing label to run all tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
