mbien commented on PR #5487: URL: https://github.com/apache/netbeans/pull/5487#issuecomment-1430797489
> And don't worry, @BradWalker ! This is something that could happen to anyone! @vieiro @BradWalker yes! This happens sometimes, so please don't worry about it. Its just that if you would have waited with the merge 1-2 days after review, I am certain someone would have noticed. why? because I for example try to look at https://github.com/apache/netbeans/actions on a daily basis to check if there is something to play whack-a-mole with, that is also how I noticed this in the first place. When someone syncs a new or old PR I would notice this too (since it appears on the all-knowing list) and probably check if its properly labeled. IMO the main lesson learned here should be to not rush PRs in, even if they seem trivial and were carefully reviewed. This could have happened with a small PR too which only covers one module or less - it likely would have required some of the [[ci] labels](https://github.com/apache/netbeans/labels?q=%5Bci%5D) too. Java PRs need Java, PHP needs PHP otherwise the correct tests won't run etc etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
