neilcsmith-net commented on PR #6500: URL: https://github.com/apache/netbeans/pull/6500#issuecomment-1740568987
It looks like this is changing the OSGi module into a standard NetBeans library wrapper? Compare the dev build with the last release - `modules/org-eclipse-jgit.jar` no longer contains the library, but points to the library files in `modules/ext`. I assume this is why you had to add things like public packages. I assume we might have to have a subproject for each JGit fragment? This is assuming that the OSGi support in the IDE supports fragment-host already. eg. see #1048 for platform. Do we also need to include `org.eclipse.jgit.gpg.bc`? The `project.xml` includes dependencies on `bcpg` and `bcprov`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
