mbien commented on PR #6500:
URL: https://github.com/apache/netbeans/pull/6500#issuecomment-1742279465

    - the individual jars have some extra notes appended to their license. What 
I did is to strip html and concat all of them into a single EDL-1.0-jgit 
license - hope thats ok
    - the API sig checks are disabled for this lib wrapper module 
`(sigtest.gen.fail.on.error=false`)
    - micronaut tests seem to work again when some dependencies are bumped, 
this took a while since the tests log so many exceptions that it is difficult 
to know what is expected and what not
    
   assuming green, going to restart with all tests active just to be sure
   
   probably going to keep this split into two commits
   
   how should we handle secondary dependencies? This is what the 4 jars would 
need:
   ```xml
       <dependency>
         <groupId>com.googlecode.javaewah</groupId>
         <artifactId>JavaEWAH</artifactId>
       </dependency>
   
       <dependency>
         <groupId>org.slf4j</groupId>
         <artifactId>slf4j-api</artifactId>
       </dependency>
   
       <dependency>
         <groupId>commons-codec</groupId>
         <artifactId>commons-codec</artifactId>
         <version>1.16.0</version>
       </dependency>
   
       <dependency>
         <groupId>com.google.code.gson</groupId>
         <artifactId>gson</artifactId>
       </dependency>
   
       <dependency>
         <groupId>org.bouncycastle</groupId>
         <artifactId>bcpg-jdk18on</artifactId>
       </dependency>
   
       <dependency>
         <groupId>org.bouncycastle</groupId>
         <artifactId>bcprov-jdk18on</artifactId>
       </dependency>
   
       <dependency>
         <groupId>org.bouncycastle</groupId>
         <artifactId>bcutil-jdk18on</artifactId>
       </dependency>
   
       <dependency>
         <groupId>org.bouncycastle</groupId>
         <artifactId>bcpkix-jdk18on</artifactId>
       </dependency>
   
       <dependency>
         <groupId>com.jcraft</groupId>
         <artifactId>jsch</artifactId>
       </dependency>
   
       <dependency>
         <groupId>com.jcraft</groupId>
         <artifactId>jzlib</artifactId>
       </dependency>
   ```
   NB's bouncy castle wrappers are at `jdk15on`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to