mbien commented on PR #6500: URL: https://github.com/apache/netbeans/pull/6500#issuecomment-1748386107
> Why would they be a friend API? That's not compatible. You'd need to replicate the exporting of packages from the OSGi manifest, surely? NB bundling third party libs as public API is only asking for trouble in my opinion. e.g see the lucene situation where the editor is stuck at 3.6. since updating that would be likely time consuming (clone the modules, deprecate the old interface etc), while the maven indexer modules which wrap the lib for internal consumption only, can update any time they want with no extra steps. I haven't actually checked if the direct or indirect [users](https://github.com/search?q=repo%3Aapache%2Fnetbeans+%3Ccode-name-base%3Eorg.eclipse.jgit%3C%2Fcode-name-base%3E&type=code) of jgit are exposing the lib in their API, if they do, it would be already too late to hide the lib wrapper. > I don't know what other compatibility implications switching from OSGi to NB module here would raise anyone is welcome to take over this PR and do the modularization part. I was only really interested in helping out with the API migration (which turned out easier than expected) and fixing some issues, e.g #6528 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
