matthiasblaesing commented on PR #6500: URL: https://github.com/apache/netbeans/pull/6500#issuecomment-1741349031
I had a quick look at this and looks sane to me. The "one module" approach might be a good option. For `org.eclipse.jgit.gpg.bc`: Yes I think this should also be included. That module provides signing support and from a quick glance this is hooked into `CommitCommand` and `TagCommand`, which makes sense for the usecases. If I remember correctly we also have an issue requesting support for signing. Looking through the modules, `org.eclipse.jgit.lfs` seems also to be sensible for the NB usecase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
