haidubogdan commented on code in PR #8401: URL: https://github.com/apache/netbeans/pull/8401#discussion_r2127530795
########## webcommon/javascript2.vue/src/org/netbeans/modules/javascript2/vue/grammar/antlr4/coloring/VueAntlrColoringLexer.g4: ########## @@ -85,16 +100,34 @@ SCRIPT_ATTR_QUOTE : '"' {this.setAttrQuoteState(true);}->type(QUOTE_ATTR); SCRIPT_ATTR_OTHER : . ->type(JAVASCRIPT_ATTR); EXIT_SCRIPT_ATTR_EOF : EOF->type(HTML),popMode; +mode INSIDE_STYLE_TAG_START; + +STYLE_LANG_ATTR : 'lang=' StringLiteral {this.setStyleLanguage();}->type(HTML); Review Comment: Same reasoning. Today in pure html the lang attribute usually identifies the language of a text (en, es, it ...). But in vue it's used to identify pre-processors language for an element like script, style. So I think it should be safe. I see that vue has some interesting lint rules for lang blocks. https://eslint.vuejs.org/rules/block-lang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists