matthiasblaesing commented on PR #8401: URL: https://github.com/apache/netbeans/pull/8401#issuecomment-2950571212
> @matthiasblaesing Beside the decoupling code, I've removed the css prep and jade dependency from the project, but kept them on test level. This must be reverted. The dependency is required, so that when `javascript2.vue` module is loaded, `css.prop` and `javascript2.jade` are made available. If not some other module loads these two modules (or they are auto activating), then `Language.find` will not be able to resolve the language and you will run into problems, because you pass a `null` language to `LanguageEmbedding.create`. Adding the too modules as test modules essentially invalidates the unittest, as now testing and runtime test different environments. The are two levels of coupling here: - General module dependency: required, as we assume the target languages are present. We are not interested in the internals, but need the modules to be available. - Implementation/code dependency: We don't need access to the source code. It was only ever used to load the language and usage can be substituted. >I've added a simple lexer test for pug script. There was a typo variable on script language lexer state, which I fixed. Makes sense. Looking at the github diff, the revert of the changes to `webcommon/javascript2.jade/nbproject/project.xml` is incomplete, there are still whitespace changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
