haidubogdan commented on PR #8401: URL: https://github.com/apache/netbeans/pull/8401#issuecomment-2945856832
> @haidubogdan thank you! Looks like a nice improvement. One final adjustment request. Would you please have a look here: > > * https://github.com/matthiasblaesing/netbeans/tree/pr-8401 > * [4bd90af](https://github.com/apache/netbeans/commit/4bd90afc6b3b9cbc79f8ae6d40424970182acfda) > > There is no need to open the `css.prep` and `javascript2.jade` modules. You only want to access the language and for that you can use the lexer api to load them at runtime based on mimetype. The new unittest ensures, that the languages don't go away silently. > > Would you check the change and see if you can integrate it? Yes, looks like a good simplification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
