haidubogdan commented on code in PR #8401: URL: https://github.com/apache/netbeans/pull/8401#discussion_r2127513395
########## webcommon/javascript2.vue/src/org/netbeans/modules/javascript2/vue/editor/lexer/VueTokenId.java: ########## @@ -37,8 +40,12 @@ public enum VueTokenId implements TokenId { HTML("html"), // NOI18N CSS("css"), // NOI18N + STYLE_SCSS("css"), // NOI18N + STYLE_LESS("css"), // NOI18N Review Comment: @matthiasblaesing you are right, the **lang** logic could use some thought on scaling. Recently I found about `stylus` preprocessor syntax. So maybe a refactor could have used a dynamic approach. Set in the tokenId primaryCategory the expected mime ex: (text/stylus) In the embedding function ``` protected LanguageEmbedding<? extends TokenId> embedding( String mime = tokenId.primaryCategory() language = (Language<? extends TokenId>) provider.findLanguage(mime ); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists