pjfanning commented on PR #103: URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/103#issuecomment-1632385845
> I found one thing but this seems a bit odd to me, making a reference that we take a header from somewhere feels wrong. > > It seems like instead we should be just copying the header (I'm this ASF standard header) and just mention code is derived from Apache Kafka? The code from Akka has the headers that it has, we can't remove them. The code here is a mix of Akka code and Kafka code. We need all the headers. LEGAL-626, Lightbend and Kafka. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
