pjfanning commented on PR #103: URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/103#issuecomment-1632488709
`based on Apache Kafka's [[org.apache.kafka.clients.producer.internals.DefaultPartitioner]]` appears in multiple places Moving the comment about the license header into scaladoc where the `based on` comment above is not a good idea (imo). Adding it as a non-scaladoc comment along side those comments means a lot of duplication - having one comment near the license header just seems the tidiest solution (to me). I have not seen any rules that forbid us from adding informational comments around the license headers to help users understand why they are there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
